There really isn't an answer to this because no one knows if the new one is going to be any better than this one. But to answer your question I would hold out because the iPhone 4 (without the "g" mind you) is plagued with problems.
Just a tidbit of info, Apple has had a pattern of releasing one per year so they will probably come out with a new one before next fall.